linux-kernel - Re: [PATCH] ACPICA: Clean up whitespace of indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171108021002.GH22644@x1>
Date:   Wed, 8 Nov 2017 10:10:02 +0800
From:   Baoquan He <bhe@...hat.com>
To:     "Moore, Robert" <robert.moore@...el.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "Schmauss, Erik" <erik.schmauss@...el.com>
Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation

On 11/07/17 at 03:09pm, Moore, Robert wrote:
> Anything like this probably happens during the conversion of ACPICA code to Linux-style code. This conversion happens after every release (monthly) of ACPICA.
> 
> Specifically indent/lindent seems to do things like this, if I remember correctly.

I found it when went through system init code, it was introduced in this
commit and looks very obvious: 

commit 19d0cfe9ddfdf7afa8d1765ab0bd2a7dd30e47c9
Author: Bob Moore <robert.moore@...el.com>
Date:   Tue Jun 10 15:54:40 2008 +0800

    ACPICA: Update DMAR and SRAT table definitions

If there has been a mechanism to check them, I am fine to leave it as is
or the tools like lindent to deal with it.

Thanks
Baoquan

> 
> > -----Original Message-----
> > From: Baoquan He [mailto:bhe@...hat.com]
> > Sent: Tuesday, November 7, 2017 2:43 AM
> > To: linux-kernel@...r.kernel.org; linux-acpi@...r.kernel.org
> > Cc: rjw@...ysocki.net; lenb@...nel.org; Moore, Robert
> > <robert.moore@...el.com>; Zheng, Lv <lv.zheng@...el.com>
> > Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation
> > 
> > PING!
> > 
> > On 10/28/17 at 09:34am, Baoquan He wrote:
> > > Use tabs (not spaces) for indentation.
> > >
> > > Signed-off-by: Baoquan He <bhe@...hat.com>
> > > ---
> > >  include/acpi/actbl1.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > > 6b8714a428b6..d8a4fc066abe 100644
> > > --- a/include/acpi/actbl1.h
> > > +++ b/include/acpi/actbl1.h
> > > @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> > >  	u16 reserved;		/* Reserved, must be zero */
> > >  	u64 base_address;
> > >  	u64 length;
> > > -       u32 reserved1;
> > > +	u32 reserved1;
> > >  	u32 flags;
> > > -       u64 reserved2;	       /* Reserved, must be zero */
> > > +	u64 reserved2;	       /* Reserved, must be zero */
> > >  };
> > >
> > >  /* Flags */
> > > --
> > > 2.5.5
> > >