linux-kernel - RE: [PATCH] scsi: megaraid: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac132cbd804bec5892ad38de3afe6a9b@mail.gmail.com>
Date:   Wed, 8 Nov 2017 21:46:31 +0530
From:   Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>
To:     Sumit Saxena <sumit.saxena@...adcom.com>,
        Kees Cook <keescook@...omium.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Kashyap Desai <kashyap.desai@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH] scsi: megaraid: Convert timers to use timer_setup()

> -----Original Message-----
> From: Sumit Saxena [mailto:sumit.saxena@...adcom.com]
> Sent: Wednesday, November 1, 2017 12:18 AM
> To: Kees Cook; Martin K. Petersen
> Cc: Kashyap Desai; Shivasharan Srikanteshwara; James E.J. Bottomley;
> PDL,MEGARAIDLINUX; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: RE: [PATCH] scsi: megaraid: Convert timers to use timer_setup()
>
> -----Original Message-----
> From: Kees Cook [mailto:keescook@...omium.org]
> Sent: Wednesday, October 25, 2017 3:37 PM
> To: Martin K. Petersen
> Cc: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley;
> megaraidlinux.pdl@...adcom.com; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] scsi: megaraid: Convert timers to use timer_setup()
>
> In preparation for unconditionally passing the struct timer_list pointer
> to all
> timer callbacks, switch to using the new timer_setup() and
> from_timer() to pass the timer pointer explicitly. Also consolidates the
> timer
> setup functions arguments, which are all identical, and corrects on-stack
> timer
> usage.
>

Ran basic sanity test for megaraid_sas part, and the changes look good.
Acked-by: Shivasharan S <shivasharan.srikanteshwara@...adcom.com>
Tested-by: Shivasharan S <shivasharan.srikanteshwara@...adcom.com>

Hannes,
Can you please take a look at the megaraid_mbox and megaraid_mm changes?

Thanks,
Shivasharan