linux-kernel - Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e673a03d-1707-fe4a-7f5d-df1466981893@codeaurora.org>
Date:   Wed, 8 Nov 2017 10:49:28 -0600
From:   Timur Tabi <timur@...eaurora.org>
To:     Sinan Kaya <okaya@...eaurora.org>, dmaengine@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new
 revision

On 11/08/2017 10:29 AM, Sinan Kaya wrote:
> +#define HIDMA_MAX_DEV_MATCH 10
> +
> +struct hidma_cap {
> +	const struct of_device_id of[HIDMA_MAX_DEV_MATCH];
> +	const struct acpi_device_id acpi[HIDMA_MAX_DEV_MATCH];
> +};

This seems wrong.  You're defining an array of size 10, but it only has 
three elements.  And the third element is a sentinel, which is typically 
used to avoid specifying the size of the array.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.