linux-kernel - Re: WARNING in usb_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1711081205460.3080-100000@iolanthe.rowland.org>
Date:   Wed, 8 Nov 2017 12:06:58 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Dmitry Vyukov <dvyukov@...gle.com>
cc:     Greg KH <gregkh@...uxfoundation.org>,
        syzbot 
        <bot+50d191d34989b5aa28596b0a2cb20c96f3ca4650@...kaller.appspotmail.com>,
        <felipe.balbi@...ux.intel.com>, <krinkin.m.u@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        <syzkaller-bugs@...glegroups.com>, Takashi Iwai <tiwai@...e.de>,
        <vskrishn@...eaurora.org>
Subject: Re: WARNING in usb_submit_urb

On Wed, 8 Nov 2017, Dmitry Vyukov wrote:

> > I don't understand how this could have happened.  The raw log explains
> > the problem:
> >
> >> [   15.138822] usb usb1: BOGUS urb flags, 2 --> 0
> >> [   15.139498] ------------[ cut here ]------------
> >> [   15.139955] WARNING: CPU: 3 PID: 2986 at drivers/usb/core/urb.c:498 usb_submit_urb+0xeb9/0x10f0
> > ...
> >> [   15.150280] RIP: 0010:usb_submit_urb+0xeb9/0x10f0
> > ...
> >> [   15.155166]  proc_do_submiturb+0x1f53/0x3860
> >
> > The "2 --> 0" means that proc_do_submiturb() tried to submit a control
> > URB (2 = PIPE_CONTROL) to an isochronous endpoint (0 = PIPE_ISOCHRONOUS).
> > But right near the start of the routine we have:
> >
> >         switch (uurb->type) {
> >         case USBDEVFS_URB_TYPE_CONTROL:
> >                 if (!usb_endpoint_xfer_control(&ep->desc))
> >                         return -EINVAL;
> >
> > So how was the warning triggered?
> 
> I don't know what happened there, but bot provided a repro for this.

Can you provide a reproducer that will run in a 32-bit userspace 
environment?

Alan Stern