linux-kernel - Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Nov 2017 14:05:02 -0500
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Joe Perches <joe@...ches.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops

Hi Joe,

Joe Perches <joe@...ches.com> writes:

> On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote:
>> The DSA switch VLAN ops pass the switchdev_trans structure down to the
>> drivers, but no one is using them and they aren't supposed to anyway.
> []
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
> []
>> @@ -410,12 +410,10 @@ struct dsa_switch_ops {
>>  	 */
>>  	int	(*port_vlan_filtering)(struct dsa_switch *ds, int port,
>>  				       bool vlan_filtering);
>> -	int	(*port_vlan_prepare)(struct dsa_switch *ds, int port,
>> -				     const struct switchdev_obj_port_vlan *vlan,
>> -				     struct switchdev_trans *trans);
>> -	void	(*port_vlan_add)(struct dsa_switch *ds, int port,
>> -				 const struct switchdev_obj_port_vlan *vlan,
>> -				 struct switchdev_trans *trans);
>> +	int (*port_vlan_prepare)(struct dsa_switch *ds, int port,
>> +				 const struct switchdev_obj_port_vlan *vlan);
>> +	void (*port_vlan_add)(struct dsa_switch *ds, int port,
>> +			      const struct switchdev_obj_port_vlan *vlan);
>>  	int	(*port_vlan_del)(struct dsa_switch *ds, int port,
>>  				 const struct switchdev_obj_port_vlan *vlan);
>
> I think this bit is slightly worse.
> Mixing alignment styles seems odd.
>
> I think it's better to either align all the (*func) uses
> on a tabstop or
> none of them.

I couldn't use a tab here as it is done in the other functions, because
of the 80-char limit. I will send a patch soon to remove all of this
alignment style in this header because it doesn't bring any value.


Thanks,

        Vivien