linux-kernel - Re: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACrMeVDtSH1dJaw7Ct8c7WTLgYuA1LdOHHQW3LggsK3E5WaRzw@mail.gmail.com>
Date:   Wed, 8 Nov 2017 15:00:45 -0500
From:   Akshay Bhat <akshay.bhat@...esys.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value

On Tue, Nov 7, 2017 at 9:30 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> On 03/11/2017 at 13:32:41 -0400, Akshay Bhat wrote:
>>       if (err != 2)
>>               return err < 0 ? err : -EIO;
>> +     err = 0;
>
> Isn't it simpler to make the function return 0 instead of err at the end?

Makes sense, fixed in v2 patch, thanks.