linux-kernel - [PATCH 1/2] dynamic_debug: fix optional/omitted ending line number to be LARGE instead of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <10a6a101-e2be-209f-1f41-54637824788e@infradead.org>
Date:   Thu, 9 Nov 2017 13:52:41 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jason Baron <jbaron@...mai.com>
Subject: [PATCH 1/2] dynamic_debug: fix optional/omitted ending line number to
 be LARGE instead of 0

From: Randy Dunlap <rdunlap@...radead.org>

line-range is supposed to treat "1-" as "1-endoffile", so
handle the special case by setting last_lineno to UINT_MAX.

Fixes this error:

dynamic_debug:ddebug_parse_query: last-line:0 < 1st-line:1
dynamic_debug:ddebug_exec_query: query parse failed

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Jason Baron <jbaron@...mai.com>
---
 lib/dynamic_debug.c |    4 ++++
 1 file changed, 4 insertions(+)

--- lnx-414-rc8.orig/lib/dynamic_debug.c
+++ lnx-414-rc8/lib/dynamic_debug.c
@@ -360,6 +360,10 @@ static int ddebug_parse_query(char *word
 				if (parse_lineno(last, &query->last_lineno) < 0)
 					return -EINVAL;
 
+				/* special case for last lineno not specified */
+				if (query->last_lineno == 0)
+					query->last_lineno = UINT_MAX;
+
 				if (query->last_lineno < query->first_lineno) {
 					pr_err("last-line:%d < 1st-line:%d\n",
 						query->last_lineno,