lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 23:06:14 +0100 From: Andrew Lunn <andrew@...n.ch> To: Vivien Didelot <vivien.didelot@...oirfairelinux.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port" On Thu, Nov 09, 2017 at 09:39:32AM -0500, Vivien Didelot wrote: > We may have to pass a port's dedicated CPU port to port-wide functions > such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. > > The DSA port-wide functions currently take a non-const struct dsa_port * > as first argument so we cannot make cpu_dp const yet, even though it'd > be more correct. Revert this patch and make cpu_dp non-const again. Hi Vivien We cannot make cpu_dp const yet. But we can change dsa_port_mdb_add() and friends to take a const, because they don't need to modify it. So NACK. And i will add the needed const attributes to these functions as part of the IGMP patchset. Andrew
Powered by blists - more mailing lists