lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 9 Nov 2017 23:06:14 +0100
From:   Andrew Lunn <>
To:     Vivien Didelot <>
        "David S. Miller" <>,
        Florian Fainelli <>
Subject: Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of

On Thu, Nov 09, 2017 at 09:39:32AM -0500, Vivien Didelot wrote:
> We may have to pass a port's dedicated CPU port to port-wide functions
> such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB.
> The DSA port-wide functions currently take a non-const struct dsa_port *
> as first argument so we cannot make cpu_dp const yet, even though it'd
> be more correct. Revert this patch and make cpu_dp non-const again.

Hi Vivien

We cannot make cpu_dp const yet. But we can change dsa_port_mdb_add()
and friends to take a const, because they don't need to modify it.


And i will add the needed const attributes to these functions as part
of the IGMP patchset.


Powered by blists - more mailing lists