linux-kernel - Re: [RFC PATCH] fs/pipe.c: implement minimum pipe size for arg==0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171109222117.st6hnkzw6hsn462w@treble>
Date:   Thu, 9 Nov 2017 16:21:17 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shankara Pailoor <sp3485@...umbia.edu>,
        Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [RFC PATCH] fs/pipe.c: implement minimum pipe size for arg==0

On Thu, Nov 09, 2017 at 02:09:03PM -0800, Randy Dunlap wrote:
> > Searching through lkml, it looks like there have been four attempts to
> > fix this issue in the last year or so, but none of them have been
> > merged.  It would be nice to finally get a fix in.
> > 
> > I agree with the patch, though I would argue that the fix belongs in
> > round_pipe_size() so that other callers don't get the same bug.
> 
> Hi Josh,
> 
> Yes, I debated with myself on where to put the patch. I made it more local
> instead of global just to have less accidental impact.
> 
> 
> Andrew has these 4 patches from Joe Lawrence in mmotm:
> 
> pipe-add-proc_dopipe_max_size-to-safely-assign-pipe_max_size.patch
> pipe-avoid-round_pipe_size-nr_pages-overflow-on-32-bit.patch
> pipe-match-pipe_max_size-data-type-with-procfs.patch
> sysctl-check-for-uint_max-before-unsigned-int-min-max.patch
> 
> 
> Hopefully they can be merged soon.
> I blame people who travel a lot.  ;)

Ah, I missed Joe's patches (and neglected to check linux-next).  Thanks!

-- 
Josh