linux-kernel - Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 14:32:23 -0800
From:   Jason Gerecke <killertofu@...il.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Ping Cheng <pinglinux@...il.com>,
        Linux Input <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

On Thu, Nov 9, 2017 at 3:42 AM, Jiri Kosina <jikos@...nel.org> wrote:
> On Mon, 6 Nov 2017, Benjamin Tissoires wrote:
>
>> > >well, this is not the cleanest way of handling this mode set, but it
>> > >is the less intrusive AFAICT.
>> > >
>> > >I was thinking that we might want to add a new field in struct
>> > >wacom_feature, but then it wouldn't make sense to keep the set mode
>> > >specifics in _wacom_query_tablet_data().
>> > >
>> > >So I am open to any better suggestion, but this one works and the
>> > >impact on other HID generic tablets is null.
>> > >
>> >
>> > Hmm. Agreed that this isn't ideal. I'd like to take a look at the
>> > descriptor, if you wouldn't mind sharing it. The hardware should be
>> > similar to other devices of ours and it might be possible to piggyback
>> > on existing code.
>> >
>>
>> Sure, here it comes in the hid-replay format (and with a recording
>> of a single dot from the pen):
>
> Jason,
>
> any word on the descriptor please, did you have time to analyze it?
>
> Merge window for 4.15 is almost there, so in case you don't want to miss
> it, I'd need your Ack/Nack/Postopne rather quickly.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

I spent some time checking for similar devices and didn't anything
with a descriptor quite like it. That said, there's a good chance that
we'll see something similar in the future...

I'm still not entirely happy with the one-off approach, but I'll but
my stamp of approval on it. We can work out a more generic way to
detect and configure these dual-resolution devices going forward :)

Reviewed-by: Jason Gerecke <jason.gerecke@...om.com>

Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one  /
(That is to say, eight) to the two,     /
But you can’t take seven from three,    /
So you look at the sixty-fours....