linux-kernel - Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 10:02:37 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>
Subject: Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy
 address from NCL_config file



On 2017/11/8 22:30, Andrew Lunn wrote:
> On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote:
>> From: Fuyun Liang <liangfuyun1@...wei.com>
>>
>> Driver gets phy address from NCL_config file and uses the phy address
>> to initialize phydev. There are 5 bits for phy address. And C22 phy
>> address has 5 bits. So 0-31 are all valid address for phy. If there
>> is no phy, it will crash. Because driver always get a valid phy address.
> Hi Lipeng
>
> Any plans for C45? The PHY address is still 5 bits, but do you need to
> get the device type from your configuration file?
>
>      Andrew
Hi Andrew

  C45 support is in Plan,   now only support C22.
  This bugfix patch is valid for C22 and C45.

  As plan , will get the device type(NULL, C22, C45) from configuration 
file after support C45.
  Do you think we must do it now? or can add it along with C45 support?

     Lipeng
> .
>