linux-kernel - [PATCH] tick/broadcast: Remove redundant code in tick_check_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <35b094f6-70e0-49f2-803a-3333d7ee2524@default>
Date:   Wed, 8 Nov 2017 20:54:51 -0800 (PST)
From:   Zhenzhong Duan <zhenzhong.duan@...cle.com>
To:     <mingo@...nel.org>, <tglx@...utronix.de>, <fweisbec@...il.com>
Cc:     Srinivas REDDY Eeda <srinivas.eeda@...cle.com>,
        Joe Jin <joe.jin@...cle.com>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] tick/broadcast: Remove redundant code in
 tick_check_new_device()

There is no way a timer used as broadcast clockevent device is also used as
percpu tick clockevent device currently.

It's better to put related code in tick_install_broadcast_device(), but I feel
it's harmless to give it back to the clockevents layer. Pls correct me if I'm
wrong.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
---
 kernel/time/tick-common.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 49edc1c..9bcc866 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev)
 
 	/*
 	 * Replace the eventually existing device by the new
-	 * device. If the current device is the broadcast device, do
-	 * not give it back to the clockevents layer !
+	 * device.
 	 */
-	if (tick_is_broadcast_device(curdev)) {
-		clockevents_shutdown(curdev);
-		curdev = NULL;
-	}
 	clockevents_exchange_device(curdev, newdev);
 	tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
 	if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
-- 
1.7.3