[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171109053529.GA12717@ravnborg.org>
Date: Thu, 9 Nov 2017 06:35:29 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: linux-kbuild@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
devicetree@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
Michal Marek <michal.lkml@...kovi.net>,
Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH 1/2] kbuild: create built-in.o automatically if parent
directory wants it
Hi Masahiro.
Thanks for picking this up.
> A key point is, the parent Makefile knows whether built-in.o is needed
> or not. If a subdirectory needs to create built-in.o, its parent can
> tell the fact when Kbuild descends into it.
Good observation!
>
> diff --git a/Makefile b/Makefile
> index 008a4e5..cc0b618 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1003,7 +1003,7 @@ $(sort $(vmlinux-deps)): $(vmlinux-dirs) ;
>
> PHONY += $(vmlinux-dirs)
> $(vmlinux-dirs): prepare scripts
> - $(Q)$(MAKE) $(build)=$@
> + $(Q)$(MAKE) $(build)=$@ need-builtin=1
The need-bultin may also be required for the shortcuts
that allows one to use:
make <dir>/
example:
make net/
And maybe selftest, documentation shortcuts too?
Other than that - looks good.
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
Sam
Powered by blists - more mailing lists