linux-kernel - Re: [PATCH] x86, build: Make genimage.sh little more quite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171109060001.GA14114@intel.com>
Date:   Thu, 9 Nov 2017 14:00:01 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     changbin.du@...el.com, mingo@...hat.com, hpa@...or.com,
        tglx@...utronix.de, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, build: Make genimage.sh little more quite

On Wed, Nov 08, 2017 at 10:01:37AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@...el.com <changbin.du@...el.com> wrote:
> 
> > From: Changbin Du <changbin.du@...el.com>
> > 
> > This change suppresses the 'dd' output and adds '-quite' parameter
> > to mkisofs tool. None of the messages matter to the user. Now:
> > 
> > $ make isoimage
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> Could you please also remove the other unnecessary lines as well, from the default 
> build log:
> 
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> The build process is using a ton of files and we don't list them. Maybe print them 
> when V=1, but not by default.
> 
> The only lines printed should be:
> 
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> 
> Users are totally not interested in the details. They want to see a single line of 
> output about which file is being built, but that's it.
>
I agree with you. So I will remove the 'Using ...', and 'set -x' if V=1.

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)