linux-kernel - Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171109061316.GE30507@voyager>
Date:   Wed, 8 Nov 2017 22:13:16 -0800
From:   Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Denys Vlasenko <dvlasenk@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Peter Anvin <hpa@...or.com>, Borislav Petkov <bp@...e.de>,
        Vlastimil Babka <vbabka@...e.cz>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Brian Gerst <brgerst@...il.com>,
        Jonathan Corbet <corbet@....net>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>, ray.huang@....com,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Chen Yucong <slaoub@...il.com>, Ingo Molnar <mingo@...nel.org>,
        Jiri Slaby <jslaby@...e.cz>, Shuah Khan <shuah@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions

On Wed, Nov 08, 2017 at 08:34:45AM -0800, Linus Torvalds wrote:
> On Wed, Nov 8, 2017 at 8:14 AM, Denys Vlasenko <dvlasenk@...hat.com> wrote:
> >
> > Can we avoid maintain emulation of these isns, by asking Wine to remove
> > their use instead?
> 
> If we ask the Wine people to remove the instruction use, that may mean
> that we can avoid the emulation in four or five _years_ once everybody
> has updated.
> 
> But it wouldn't mean that we could avoid it today.
> 
> We *do* probably want to print a warning about these instructions,
> whether emulated or not. If emulated, we want to print a warning about
> the emulation being expensive (as a nudge to the Wine people to not do
> that), and if _not_ emulated, we'd want to print a warning about why
> people suddenly got a SIGSEGV in case there are programs that use
> those instructions that people didn't even think of.

I am preparing a set of complementary patches now that the series made it
to the tip tree. I can include these updates as well.
> 
> But make it ratelimit the warning (perhaps at most once every few
> minutes or whatever), so that people won't flood message logs just
> because they have old stupid programs that use those things.

Will do.

Thanks and BR,
Ricardo