linux-kernel - Re: [PATCH 6/8] staging: ccree: simplify pm manager using local var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 08:27:28 +0200
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        driverdev-devel@...uxdriverproject.org,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Ofir Drang <ofir.drang@....com>
Subject: Re: [PATCH 6/8] staging: ccree: simplify pm manager using local var

On Tue, Nov 7, 2017 at 12:43 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote:
>> --- a/drivers/staging/ccree/ssi_pm.c
>> +++ b/drivers/staging/ccree/ssi_pm.c
>> @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev)
>>  int cc_pm_get(struct device *dev)
>>  {
>>       int rc = 0;
>> +     struct ssi_drvdata *drvdata =
>> +             (struct ssi_drvdata *)dev_get_drvdata(dev);
>
> No need to cast:
>
>         struct ssi_drvdata *drvdata = dev_get_drvdata(dev);
>

The same unneeded cast appears at other places in the file, so I opted
to add a patch addressing all these location rather then change this one.

I hope it's OK.

Gilad


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru