lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 09 Nov 2017 09:16:52 +0100 From: Takashi Iwai <tiwai@...e.de> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Ruslan Bilovol <ruslan.bilovol@...il.com>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support On Thu, 09 Nov 2017 09:04:58 +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 08, 2017 at 03:38:35PM +0100, Takashi Iwai wrote: > > On Tue, 07 Nov 2017 03:01:20 +0100, > > Ruslan Bilovol wrote: > > > > > > Recently released USB Audio Class 3.0 specification > > > introduces many significant changes comparing to > > > previous versions, like > > > - new Power Domains, support for LPM/L1 > > > - new Cluster descriptor > > > - changed layout of all class-specific descriptors > > > - new High Capability descriptors > > > - New class-specific String descriptors > > > - new and removed units > > > - additional sources for interrupts > > > - removed Type II Audio Data Formats > > > - ... and many other things (check spec) > > > > > > It also provides backward compatibility through > > > multiple configurations, as well as requires > > > mandatory support for BADD (Basic Audio Device > > > Definition) on each ADC3.0 compliant device > > > > > > This patch adds initial support of UAC3 specification > > > that is enough for Generic I/O Profile (BAOF, BAIF) > > > device support from BADD document. > > > > > > Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com> > > > > The patch looks good, but the timing is fairly late for merging to > > 4.15. > > Isn't kbuild barfing all over these? Is that because of the cross-tree > changes needed? No, it's just local to the audio driver, plus a few include/linux/usb/*.h modification / addition. So there shouldn't be a big breakage in that regard. > > So from my side, the primary question is whether the changes in USB > > (audio) header files are OK for USB guys. > > > > Greg, could you check these changes and give an ack if it's OK to > > merge? Or if you prefer postpone, just let me know. > > I don't object to the USB header changes, as long as the fixes you point > out are made :) Good to hear. Could you give your acked-by once after reviewing the patch? I think this should go through sound tree. Thanks! Takashi
Powered by blists - more mailing lists