linux-kernel - Re: [PATCH] net: sfc: remove redundant variable start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 08:39:36 +0000
From:   Bert Kenward <bkenward@...arflare.com>
To:     Colin King <colin.king@...onical.com>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Edward Cree <ecree@...arflare.com>, <netdev@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: sfc: remove redundant variable start

On 09/11/17 08:01, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable start is assigned but never read hence it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Bert Kenward <bkenward@...arflare.com>

Thanks Colin.

> ---
>  drivers/net/ethernet/sfc/ptp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 56c2db398def..caa89bf7603e 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx,
>  	struct pps_event_time now;
>  	struct timespec64 limit;
>  	struct efx_ptp_data *ptp = efx->ptp_data;
> -	struct timespec64 start;
>  	int *mc_running = ptp->start.addr;
>  
>  	pps_get_ts(&now);
> -	start = now.ts_real;
>  	limit = now.ts_real;
>  	timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS);
>  
>