linux-kernel - Re: [PATCH] media: coda: remove definition of CODA_STD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1510218675.7659.0.camel@pengutronix.de>
Date:   Thu, 09 Nov 2017 10:11:15 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Martin Kepplinger <martink@...teo.de>, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: coda: remove definition of CODA_STD_MJPG

On Wed, 2017-11-08 at 19:58 +0100, Martin Kepplinger wrote:
> According to i.MX VPU API Reference Manuals the MJPG video codec is
> refernced to by number 7, not 3.
> 
> Also Philipp pointed out that this value is only meant to fill in
> CMD_ENC_SEQ_COD_STD for encoding, only on i.MX53. It was never written
> to any register, and even if defined correctly, wouldn't be needed
> for i.MX6.
> 
> So avoid confusion and remove this definition.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>
> ---
>  drivers/media/platform/coda/coda_regs.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h
> index 38df5fd9a2fa..35e620c7f1f4 100644
> --- a/drivers/media/platform/coda/coda_regs.h
> +++ b/drivers/media/platform/coda/coda_regs.h
> @@ -254,7 +254,6 @@
>  #define		CODA9_STD_H264					0
>  #define		CODA_STD_H263					1
>  #define		CODA_STD_H264					2
> -#define		CODA_STD_MJPG					3
>  #define		CODA9_STD_MPEG4					3
>  
>  #define CODA_CMD_ENC_SEQ_SRC_SIZE				0x190

Thanks,

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp