lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 09 Nov 2017 18:16:15 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        kernel-janitors@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] extcon: max8997: Delete an unnecessary variable
 initialisation in max8997_muic_set_path()

Hi,

On 2017년 11월 09일 18:05, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 9 Nov 2017 10:00:08 +0100
> 
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/extcon/extcon-max8997.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 8152790d72e1..9f30f4929b72 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -204,7 +204,7 @@ static int max8997_muic_set_debounce_time(struct max8997_muic_info *info,
>  static int max8997_muic_set_path(struct max8997_muic_info *info,
>  		u8 val, bool attached)
>  {
> -	int ret = 0;
> +	int ret;
>  	u8 ctrl1, ctrl2 = 0;
>  
>  	if (attached)
> 

Applied it.
But, it will be merged to v4.16-rc1.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Powered by blists - more mailing lists