linux-kernel - Re: [PATCH 02/31] nds32: Kernel booting and initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 17:49:24 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Greentime <greentime@...estech.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        netdev <netdev@...r.kernel.org>,
        Vincent Chen <vincentc@...estech.com>
Subject: Re: [PATCH 02/31] nds32: Kernel booting and initialization

2017-11-08 21:38 GMT+08:00 Rob Herring <robh+dt@...nel.org>:
> On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu <green.hu@...il.com> wrote:
>> From: Greentime Hu <greentime@...estech.com>
>>
>
> Commit message needed.

Thanks.
I will add more commit messages in the next version patch.

>
>> Signed-off-by: Vincent Chen <vincentc@...estech.com>
>> Signed-off-by: Greentime Hu <greentime@...estech.com>
>> ---
>
>> +       /* it could update max_pfn */
>> +       if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
>> +               max_low_pfn = max_pfn;
>> +       else {
>> +               max_low_pfn = MAXMEM_PFN + ram_start_pfn;
>> +#ifndef CONFIG_HIGHMEM
>
> Use IS_ENABLED here and other ifdef's if possible.
>

Thanks
I will try to use IS_ENABLED here in the next version patch.

>> +               max_pfn = MAXMEM_PFN + ram_start_pfn;
>> +#endif
>> +       }
>
>
>> +static int __init nds32_device_probe(void)
>> +{
>> +       return of_platform_populate(NULL, NULL, NULL, NULL);
>> +}
>> +
>> +device_initcall(nds32_device_probe);
>
> You can drop this. The core code will call of_platform_populate for you.

Thanks.
I will drop this in the next version patch.