lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 10:05:14 +0000 From: Gabriele Paoloni <gabriele.paoloni@...wei.com> To: dann frazier <dann.frazier@...onical.com> CC: "catalin.marinas@....com" <catalin.marinas@....com>, "will.deacon@....com" <will.deacon@....com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "frowand.list@...il.com" <frowand.list@...il.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "rafael@...nel.org" <rafael@...nel.org>, "arnd@...db.de" <arnd@...db.de>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>, "mark.rutland@....com" <mark.rutland@....com>, "brian.starkey@....com" <brian.starkey@....com>, "olof@...om.net" <olof@...om.net>, "benh@...nel.crashing.org" <benh@...nel.crashing.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, Linuxarm <linuxarm@...wei.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "minyard@....org" <minyard@....org>, John Garry <john.garry@...wei.com>, "xuwei (O)" <xuwei5@...ilicon.com>, "zhichang.yuan" <yuanzhichang@...ilicon.com> Subject: RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings Hi Dann [...] > > + > > +#define START_WORK 0x01 > > Any reason not to put this in the LPC_ namespace as well? No, not really. We'll make it consistent in the next patchset > > > +/* The minimal nanosecond interval for each query on LPC cycle > status. */ [...] > > + * hisilpc_target_in - trigger a series of lpc cycles to read > required data > > + * from target peripheral. > > + * @pdev: pointer to hisi lpc device > > It's now lpcdev > Thanks, we'll change it. > > + * @para: some parameters used to control the lpc I/O operations [...] > > + * @pio: the target I/O port address. > > @outval & @pio are in the opposite order of the actual function Thanks, we'll change it. > [...] > > + lpcdev->io_host->devpara = NULL; > > + dev_err(dev, "OF: scan hisilpc children got failed(%d)\n", > > + ret); > > nit: Maybe "OF: scanning hisilpc children failed(%d)" ? > Yes, thanks we'll change it. > > + return ret; > > + } > > + > > + dev_info(dev, "hslpc end probing. range[%pa - sz:%pa]\n", > > + &lpcdev->io_host->io_start, > > + &lpcdev->io_host->size); > > + > > + return ret; > > +} > > > -dann
Powered by blists - more mailing lists