linux-kernel - Re: [PATCH 01/17] ASoC: tlv320aic31xx: General source formatting cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171109124143.mpolqcvsdzj2t6tv@sirena.co.uk>
Date:   Thu, 9 Nov 2017 12:41:43 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Andrew F. Davis" <afd@...com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/17] ASoC: tlv320aic31xx: General source formatting
 cleanup

On Wed, Nov 08, 2017 at 06:27:25PM -0600, Andrew F. Davis wrote:
> Simple non-functional changes including:
> 
>  * Fix header copyright tags
>  * Fix spelling errors
>  * Reformat code for easier reading
>  * Move some code blocks to a more natural ordering
>  * Remove unneeded code
>  * Remove assignments that are always overridden
>  * Normalize function return paths
> 
> Signed-off-by: Andrew F. Davis <afd@...com>

There's other things in here like adding error reporting...  please
don't send changes like this, if you want to do cleanups you should
split them up in the same way you would other changes.  Bigger patches
are harder to review especially if they're not repetitive examples of
the same pattern.  

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)