linux-kernel - Re: [1/2] MIPS: Kconfig: Set default MIPS system type as generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171109125758.GA7939@jhogan-linux.mipstec.com>
Date:   Thu, 9 Nov 2017 12:57:58 +0000
From:   James Hogan <james.hogan@...s.com>
To:     Matt Redfearn <matt.redfearn@...s.com>
CC:     Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>,
        David Howells <dhowells@...hat.com>,
        Borislav Petkov <bp@...e.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [1/2] MIPS: Kconfig: Set default MIPS system type as generic

On Wed, Dec 14, 2016 at 03:09:42PM +0000, Matt Redfearn wrote:
> The generic MIPS system type allows building a board agnostic kernel and
> should be the default starting point for users, so set it as the default
> system type in Kconfig.
> Since ip22 is no longer the default, update ip22_defconfig to select
> CONFIG_SGI_IP22.
> 
> Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>

Thanks, both patches applied for 4.15.

Cheers
James

> ---
> 
> This patch "fixes" the build errors reported by kernelci.org for the
> allnoconfig, generic_defconfig and tinyconfig targets.
> 
> There is another workaround for the actual build failure in patchwork
> here https://patchwork.linux-mips.org/patch/14397/, but since that patch
> just works around a toolchain bug it is not ideal either. Since
> toolchains that produce failures here are out in the wild, banning
> binutils 2.25 & 2.26 doesn't seem helpful as that will just trigger more
> problems.
> 
> So perhaps the best thing to do is to update the default system to
> something which does not suffer the issue and is additionally more modern
> and actively maintained.
> 
> ---
>  arch/mips/Kconfig                | 2 +-
>  arch/mips/configs/ip22_defconfig | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index b3c5bde43d34..005085e75a66 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -71,7 +71,7 @@ menu "Machine selection"
>  
>  choice
>  	prompt "System type"
> -	default SGI_IP22
> +	default MIPS_GENERIC
>  
>  config MIPS_GENERIC
>  	bool "Generic board-agnostic MIPS kernel"
> diff --git a/arch/mips/configs/ip22_defconfig b/arch/mips/configs/ip22_defconfig
> index 5d83ff755547..4b9e759d8b87 100644
> --- a/arch/mips/configs/ip22_defconfig
> +++ b/arch/mips/configs/ip22_defconfig
> @@ -1,3 +1,4 @@
> +CONFIG_SGI_IP22=y
>  CONFIG_ARC_CONSOLE=y
>  CONFIG_CPU_R5000=y
>  CONFIG_NO_HZ=y

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)