linux-kernel - Re: [PATCH v2 2/2] sparc: pass endianness info to sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMHZB6H4dGwMM+nPbDg0SEDBkRF7_R_LZ-bMWUzreBYDj3U3Sg@mail.gmail.com>
Date:   Thu, 9 Nov 2017 14:13:07 +0100
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Sam Ravnborg <sam@...nborg.org>, sparclinux@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Babu Moger <babu.moger@...cle.com>
Subject: Re: [PATCH v2 2/2] sparc: pass endianness info to sparse

On Thu, Nov 9, 2017 at 9:34 AM, Christoph Hellwig <hch@...radead.org> wrote:
> On Thu, Nov 09, 2017 at 07:16:52AM +0100, Luc Van Oostenryck wrote:
>> sparc is big-endian only but sparse assumes the same endianness
>> as the building machine.
>> This is problematic for code which expect __BYTE_ORDER__ being
>> correctly predefined by the compiler which sparse can then
>> pre-process differently from what gcc would, depending on the
>> building machine endianness.
>>
>> Fix this by letting sparse know about the architecture endianness.
>
> You're posted patches for this for about half a dozen architectures
> now, but we also now have generic Kconfig symbols for the byte order.
>
> I'd much rather see this done in generic code than hacking it up
> everywhere.

OK, when I wrote these patch (in June, IIRC) there wasn't yet the
generic Kconfig symbol. I'll see what can now be generic and what
need to stay specific (for example, ARM need __ARME{L,B}__,
ARM64 & MIPS are in the same situation as are a few others archs).

-- Luc Van Oostenryck