linux-kernel - Re: bq2415x_charger: Use common error handling code in bq2415x_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <935e992c-e5ee-841b-c42a-4a7bf891d984@users.sourceforge.net>
Date:   Thu, 9 Nov 2017 14:22:18 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Pali Rohár <pali.rohar@...il.com>,
        linux-pm@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>, Sebastian Reichel <sre@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: bq2415x_charger: Use common error handling code in
 bq2415x_timer_work()

>> Which information (or wording) would you find more appropriate
>> at these places?
> 
> Hi! Basically dropping your patch and instead of the "Unknown error"
> return to user reason why BQ2415X_BOOST_MODE_STATUS or
> BQ2415X_FAULT_STATUS commands failed. Or at least instead of the
> "Unknown error" write "Unknown error during BQ2415X_FAULT_STATUS".

Can the error description become better?

Regards,
Markus