linux-kernel - Re: [PATCH v10 13/18] x86/insn-eval: Add utility functions to get segment selector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 14:50:09 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Brian Gerst <brgerst@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Huang Rui <ray.huang@....com>, Jiri Slaby <jslaby@...e.cz>,
        Jonathan Corbet <corbet@....net>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Chen Yucong <slaoub@...il.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Shuah Khan <shuah@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        ricardo.neri@...el.com,
        Adam Buchbinder <adam.buchbinder@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Qiaowei Ren <qiaowei.ren@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Thomas Garnier <thgarnie@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH v10 13/18] x86/insn-eval: Add utility functions to get
 segment selector


* Arnd Bergmann <arnd@...db.de> wrote:

> On Fri, Oct 27, 2017 at 10:25 PM, Ricardo Neri
> <ricardo.neri-calderon@...ux.intel.com> wrote:
> 
> > diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
> > index 02aff08..1c78580 100644
> > --- a/arch/x86/include/asm/inat.h
> > +++ b/arch/x86/include/asm/inat.h
> > @@ -97,6 +97,16 @@
> >  #define INAT_MAKE_GROUP(grp)   ((grp << INAT_GRP_OFFS) | INAT_MODRM)
> >  #define INAT_MAKE_IMM(imm)     (imm << INAT_IMM_OFFS)
> >
> > +/* Identifiers for segment registers */
> > +#define INAT_SEG_REG_IGNORE    0
> > +#define INAT_SEG_REG_DEFAULT   1
> > +#define INAT_SEG_REG_CS                2
> > +#define INAT_SEG_REG_SS                3
> > +#define INAT_SEG_REG_DS                4
> > +#define INAT_SEG_REG_ES                5
> > +#define INAT_SEG_REG_FS                6
> > +#define INAT_SEG_REG_GS                7
> > +
> 
> linux-next still reports a warning because of this change:
> 
> Warning: synced file at 'tools/objtool/arch/x86/include/asm/inat.h'
> differs from latest kernel version at 'arch/x86/include/asm/inat.h'
> 
> Should the same change be applied to the objtool file in the
> tip:x86/mpx branch?

No, the best flow is that the headers will be synced once both components are 
upstream.

This is an integration artifact - and we don't want to 'pre sync', because what 
happens if Linus has to reject the arch/x86/include/asm/inat.h changes for 
whatever reason, and the tooling changes go upstream first?

Thanks,

	Ingo