lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 13:59:43 +0000 From: Colin King <colin.king@...onical.com> To: Pravin Shelar <pshelar@...ira.com>, "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org, dev@...nvswitch.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] openvswitch: add null pointer check on upcall From: Colin Ian King <colin.king@...onical.com> upcall may be assigned a NULL pointer as genlmsg_put can potentially return a NULL. Add a null check to avoid a null pointer dereference on upcall. Detected by CoverityScan, CID#728404 ("Dereference null return value") Fixes: commit ccb1352e76cf ("net: Add Open vSwitch kernel components.") Signed-off-by: Colin Ian King <colin.king@...onical.com> --- net/openvswitch/datapath.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 4d38ac044cee..e8fb3d76fa6e 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -461,6 +461,10 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, upcall = genlmsg_put(user_skb, 0, 0, &dp_packet_genl_family, 0, upcall_info->cmd); + if (!upcall) { + err = -ENOBUFS; + goto out; + } upcall->dp_ifindex = dp_ifindex; err = ovs_nla_put_key(key, key, OVS_PACKET_ATTR_KEY, false, user_skb); -- 2.14.1
Powered by blists - more mailing lists