lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 02:26:53 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Baolin Wang <baolin.wang@...eadtrum.com> Cc: a.zummo@...ertech.it, robh+dt@...nel.org, mark.rutland@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org, broonie@...nel.org, baolin.wang@...aro.org Subject: Re: [PATCH v2 2/2] rtc: sprd: Add Spreadtrum RTC driver Hi, On 08/11/2017 at 17:16:15 +0800, Baolin Wang wrote: > +static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) > +{ > + struct sprd_rtc *rtc = dev_get_drvdata(dev); > + time64_t secs; > + int ret; > + I would have expected a check for SPRD_RTC_POWER_RESET_FLAG here. > + ret = sprd_rtc_get_secs(rtc, SPRD_RTC_TIME, &secs); > + if (ret) > + return ret; > + > + rtc_time64_to_tm(secs, tm); > + return rtc_valid_tm(tm); > +} > + > +static int sprd_rtc_set_time(struct device *dev, struct rtc_time *tm) > +{ > + struct sprd_rtc *rtc = dev_get_drvdata(dev); > + time64_t secs = rtc_tm_to_time64(tm); > + And you need to reset SPRD_RTC_POWER_RESET_FLAG here > + return sprd_rtc_set_secs(rtc, SPRD_RTC_TIME, secs); > +} > + -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists