lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Nov 2017 16:47:15 -0200 From: Breno Leitao <leitao@...ian.org> To: Ram Pai <linuxram@...ibm.com> Cc: mpe@...erman.id.au, mingo@...hat.com, akpm@...ux-foundation.org, corbet@....net, arnd@...db.de, linux-arch@...r.kernel.org, ebiederm@...ssion.com, linux-doc@...r.kernel.org, x86@...nel.org, dave.hansen@...el.com, linux-kernel@...r.kernel.org, mhocko@...nel.org, linux-mm@...ck.org, paulus@...ba.org, aneesh.kumar@...ux.vnet.ibm.com, linux-kselftest@...r.kernel.org, bauerman@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org, khandual@...ux.vnet.ibm.com Subject: Re: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction Hi Ram, On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote: > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext) > > trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO]; > ip = uctxt->uc_mcontext.gregs[REG_IP_IDX]; > - fpregset = uctxt->uc_mcontext.fpregs; > - fpregs = (void *)fpregset; Since you removed all references for fpregset now, you probably want to remove the declaration of the variable above. > @@ -219,20 +224,21 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext) > * state. We just assume that it is here. > */ > fpregs += 0x70; > -#endif > - pkey_reg_offset = pkey_reg_xstate_offset(); With this code, you removed all the reference for variable pkey_reg_offset, thus, its declaration could be removed also. > - *(u64 *)pkey_reg_ptr = 0x00000000; > + dprintf1("si_pkey from siginfo: %lx\n", si_pkey); > +#if defined(__i386__) || defined(__x86_64__) /* arch */ > + dprintf1("signal pkey_reg from xsave: %016lx\n", *pkey_reg_ptr); > + *(u64 *)pkey_reg_ptr &= reset_bits(si_pkey, PKEY_DISABLE_ACCESS); > +#elif __powerpc64__ Since the variable pkey_reg_ptr is only used for Intel code (inside #ifdefs), you probably want to #ifdef the variable declaration also, avoid triggering "unused variable" warning on non-Intel machines.
Powered by blists - more mailing lists