linux-kernel - Re: [PATCH] powerpc/powernv: Fix IMC_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877euzp3mo.fsf@concordia.ellerman.id.au>
Date:   Fri, 10 Nov 2017 08:02:23 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Anju T Sudhakar <anju@...ux.vnet.ibm.com>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        maddy@...ux.vnet.ibm.com, anju@...ux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv: Fix IMC_MAX_PMU macro

Anju T Sudhakar <anju@...ux.vnet.ibm.com> writes:

> IMC_MAX_PMU is used for static storage (per_nest_pmu_arr) which holds
> nest pmu information. Current value for the macro is 32 based on
> the initial number of nest pmu units supported by the nest microcode.
> Currently 29 nest units are enabled based on the system configuration.
> But going forward, microcode could support more nest units (max of 64
> nest units). Hence fix the value for the macro.

There should be no reason to have a hard coded limit.

We should just fix the code to dynamically size the array based on
what's found in the device tree.

cheers

> Fixes:8f95faaac56c1 ('powerpc/powernv: Detect and create IMC device')
> Signed-off-by: Anju T Sudhakar <anju@...ux.vnet.ibm.com>
> ---
>  arch/powerpc/include/asm/imc-pmu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/imc-pmu.h b/arch/powerpc/include/asm/imc-pmu.h
> index 7f74c28..f9f0f2e 100644
> --- a/arch/powerpc/include/asm/imc-pmu.h
> +++ b/arch/powerpc/include/asm/imc-pmu.h
> @@ -23,7 +23,7 @@
>  /*
>   * For static allocation of some of the structures.
>   */
> -#define IMC_MAX_PMUS			32
> +#define IMC_MAX_PMUS			64
>  
>  /*
>   * Compatibility macros for IMC devices
> -- 
> 2.7.4