linux-kernel - Re: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20b8f1d2-f817-469f-afbf-66f25d6f8c46@ti.com>
Date:   Fri, 10 Nov 2017 11:52:21 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Bao Xiaowei <xiaowei.bao@....com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <catalin.marinas@....com>,
        <will.deacon@....com>, <bhelgaas@...gle.com>,
        <shawnguo@...nel.org>, <madalin.bucur@....com>,
        <sumit.garg@....com>, <yangbo.lu@....com>, <hongtao.jia@....com>,
        <Yuantian.Tang@....com>, <leoyang.li@....com>,
        <jingoohan1@...il.com>, <pbrobinson@...il.com>,
        <songxiaowei@...ilicon.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <Zhiqiang.Hou@....com>,
        <mingkai.hu@....com>, <Minghuan.Lian@....com>
Subject: Re: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

Hi Bao,

On Friday 10 November 2017 09:18 AM, Bao Xiaowei wrote:
> Add the property of inbound and outbound windows number for ep
> driver.
> 
> Signed-off-by: Bao Xiaowei <xiaowei.bao@....com>
> Acked-by: Minghuan Lian <minghuan.Lian@....com>
> ---
>  v2:
>  - no change
>  v3:
>  - modify the commit message
>  v4:
>  - no change
> 
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)

$subject should start with something like
arm64: dts: ls1046a: **
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 06b5e12d04d8..f8332669663c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -674,6 +674,8 @@
>  			device_type = "pci";
>  			dma-coherent;
>  			num-lanes = <4>;
> +			num-ib-windows = <6>;
> +			num-ob-windows = <6>;

EP specific properties shouldn't be added in RC dt node. Ideally you should
have a separate dt node for RC and EP.

Thanks
Kishon