linux-kernel - Re: [PATCH v2] locking/lockdep: Revise Documentation/locking/crossrelease.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f2de6c8-ef4b-070d-a81d-eed677bcce35@lge.com>
Date:   Fri, 10 Nov 2017 16:41:18 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     peterz@...radead.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-block@...r.kernel.org, kernel-team@....com
Subject: Re: [PATCH v2] locking/lockdep: Revise
 Documentation/locking/crossrelease.txt

On 11/10/2017 4:30 PM, Ingo Molnar wrote:
> 
> * Byungchul Park <byungchul.park@....com> wrote:
> 
>>      Event C depends on event A.
>>      Event A depends on event B.
>>      Event B depends on event C.
>>   
>> -   NOTE: Precisely speaking, a dependency is one between whether a
>> -   waiter for an event can be woken up and whether another waiter for
>> -   another event can be woken up. However from now on, we will describe
>> -   a dependency as if it's one between an event and another event for
>> -   simplicity.
> 
> Why was this explanation removed?
> 
>> -Lockdep tries to detect a deadlock by checking dependencies created by
>> -lock operations, acquire and release. Waiting for a lock corresponds to
>> -waiting for an event, and releasing a lock corresponds to triggering an
>> -event in the previous section.
>> +Lockdep tries to detect a deadlock by checking circular dependencies
>> +created by lock operations, acquire and release, which are wait and
>> +event respectively.
> 
> What? You changed a readable paragraph into an unreadable one.
> 
> Sorry, this text needs to be acked by someone with good English skills, and I
> don't have the time right now to fix it all up. Please send minimal, obvious
> typo/grammar fixes only.

I will send one including minimal fixes at the next spin.

-- 
Thanks,
Byungchul