linux-kernel - Re: [PATCH] perf parse events: Fix invalid precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171110103900.GA10233@krava>
Date:   Fri, 10 Nov 2017 11:39:00 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Mengting Zhang <zhangmengting@...wei.com>
Cc:     namhyung@...nel.org, alexander.shishkin@...ux.intel.com,
        acme@...nel.org, Linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, huawei.libin@...wei.com,
        wangnan0@...wei.com
Subject: Re: [PATCH] perf parse events: Fix invalid precise_ip handling

On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote:

SNIP

> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 39b1596..25225f4 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1369,6 +1369,32 @@ struct event_modifier {
>  	int pinned;
>  };
>  
> +static int perf_get_max_precise_ip(void)
> +{
> +       int max_precise_ip = 0;
> +       struct perf_event_attr attr = {
> +               .type   = PERF_TYPE_HARDWARE,
> +               .config = PERF_COUNT_HW_CPU_CYCLES,
> +       };
> +
> +       event_attr_init(&attr);
> +       
> +       attr.precise_ip = 3;
> +       attr.sample_period = 1;
> +
> +       while (attr.precise_ip != 0) {
> +               int fd = sys_perf_event_open(&attr, 0, -1, -1, 0);
> +               if (fd != -1){
> +                       close(fd);
> +                       break;
> +               }
> +               --attr.precise_ip;
> +       }
> +       max_precise_ip = attr.precise_ip;
> +
> +       return max_precise_ip;
> +}

we already have a function for that, please check perf_event_attr__set_max_precise_ip

also I think the precise level is not generic for all the events,
so you should check it for specific perf_event_attr later, when
the attr is ready, not in modifier parsing

thanks,
jirka