linux-kernel - Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mv3ue1k6.fsf@linux.intel.com>
Date:   Fri, 10 Nov 2017 14:54:49 +0200
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Abhijeet@...r.kernel.org, Kumar@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        abhijeet kumar <abhijeet.kumar@...el.com>,
        Jaejoong Kim <climbbb.kim@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface


Hi,

Abhijeet@...r.kernel.org, Kumar@...r.kernel.org writes:

these emails don't exist. Fix your email client.

> From: abhijeet kumar <abhijeet.kumar@...el.com>

capitalize names

> Runtime resume USB device in order to ensure that PM framework
> knows that the we might be using the device in a short time and doesn't
> autosuspend the device while we updating it's interface.

this doesn't tell me about any problem. What, exactly, are you trying to
fix?

> Signed-off-by: abhijeet kumar <abhijeet.kumar@...el.com>

capitalize names

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 371a07d874a3..658603ed779e 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1305,6 +1305,9 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
>  	if (iface->unregistering)
>  		return -ENODEV;
>  
> +	/*Letting runtime PM now that we wish to use the device in a short time
> +	 *pm_runtime_get(&iface->dev);
> +	 */

why is it so that adding commented out code help? Did you *really* test
this at all?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)