linux-kernel - Re: [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171110013417.GB9783@fury>
Date:   Thu, 9 Nov 2017 17:34:17 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>
Cc:     platform-driver-x86@...r.kernel.org, linux-input@...r.kernel.org,
        AceLan Kao <acelan.kao@...onical.com>,
        Andy Shevchenko <andy@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate
 press/release events

On Thu, Nov 09, 2017 at 11:44:33PM +0100, Stefan Brüns wrote:
> Currently all key events use autorelease, but this forbids use as a
> modifier key.
> 
> As all event codes come in even/odd pairs, we can lookup the key type
> (KE_KEY/KE_IGNORE) for the key up event corresponding to the currently
> handled key down event. If the key up is ignored, we keep setting the
> autorelease flag for the key down.
> 

What is the use-case for using these buttons as modifiers? I'm picturing one of
these devices in tablet mode, with a physical Windows button. What other action
does a user want to modify by holding the Windows button down? Or is there
another scenario we're trying to support here?

-- 
Darren Hart
VMware Open Source Technology Center