linux-kernel - Re: n900 in next-20170901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171110153620.GO28152@atomide.com>
Date:   Fri, 10 Nov 2017 07:36:20 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:     Pavel Machek <pavel@....cz>, pali.rohar@...il.com, sre@...nel.org,
        kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, khilman@...nel.org,
        aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
        patrikbachan@...il.com, serge@...lyn.com, abcloriens@...il.com,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Russell King <linux@...linux.org.uk>
Subject: Re: n900 in next-20170901

* Joonsoo Kim <iamjoonsoo.kim@....com> [171110 06:34]:
> On Thu, Nov 09, 2017 at 07:26:10PM -0800, Tony Lindgren wrote:
> > +#define OMAP34XX_SRAM_PHYS	0x40200000
> > +#define OMAP34XX_SRAM_VIRT	0xd0010000
> > +#define OMAP34XX_SRAM_SIZE	0x10000
> 
> For my testing environment, vmalloc address space is started at
> roughly 0xe0000000 so 0xd0010000 would not be valid.

Well we can map it anywhere we want, got any preferences?

Just that the current save_secure_ram_context uses "high_mask"
of 0xffff to translate the address. To make this more flexible,
we need the save_secure_ram_context changes too. So we might
want to do the static mapping and save_secure_ram_context changes
as a single patch.

> And, PHYS can be different according to the system type. Maybe either
> OMAP3_SRAM_PUB_PA or OMAP3_SRAM_PA. It seems that SIZE and TYPE should
> be considered, too. My understanding is correct?

We can have a static map for the whole SRAM area, see function
__arm_ioremap_pfn_caller() for the comment "Try to reuse one of the
static mapping whenever possible". So the different public SRAM start
addresses and sizes don't matter there.

Regards,

Tony