linux-kernel - Re: [PATCH] staging: pi433: fix missing break in switch statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2ab2dae-f367-0984-088b-0a05d8cc6327@canonical.com>
Date:   Fri, 10 Nov 2017 17:04:08 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Marcus Wolf <marcus.wolf@...rthome-wolf.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marcus Wolf <linux@...f-Entwicklungen.de>,
        Al Viro <viro@...iv.linux.org.uk>, devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: fix missing break in switch statement.

On 10/11/17 16:49, Marcus Wolf wrote:
> Hi all!
> 
> Tryed to cross check...
> 
> Don't get it, sorry.
> 
> On my private version control (my SVN), where I initially developed the
> driver the break isn't missing.
> Same with my git copy of Gregs staging tree. Break is there...
> 
> Who removed it, why is it missing in Colins copy?
> 
> Am I working on a wrong version?

I was working on the latest, that got landed into linux-next. This had
picked up some modifications from Al-Viro.

Hope that clarifies things

Colin

> 
> marcus@...top-Wolf:~/staging/drivers/staging/pi433$ git remote show origin
> * remote origin
>   Fetch URL:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>   Push  URL:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> 
> 
> Can anybody help me?
> 
> Thanks,
> 
> Marcus
> 
> 
> Am 09.11.2017 um 19:19 schrieb Colin King:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
>> to the default case and errorenously return -EINVAL. Fix this by
>> adding in missing break.
>>
>> Detected by CoverityScan, CID#1461286 ("Missing break in switch")
>>
>> Fixes: f81f0b5c9a30 ("pi433: sanitize ioctl")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>   drivers/staging/pi433/pi433_if.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/pi433/pi433_if.c
>> b/drivers/staging/pi433/pi433_if.c
>> index 3bcb59811cdf..a960fe2e7875 100644
>> --- a/drivers/staging/pi433/pi433_if.c
>> +++ b/drivers/staging/pi433/pi433_if.c
>> @@ -811,6 +811,7 @@ pi433_ioctl(struct file *filp, unsigned int cmd,
>> unsigned long arg)
>>           }
>>             mutex_unlock(&device->rx_lock);
>> +        break;
>>       default:
>>           retval = -EINVAL;
>>       }
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html