linux-kernel - Re: [PATCH] Input: sidewinder - mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171110182427.45cji4wltdb2toh6@dtor-ws>
Date:   Fri, 10 Nov 2017 10:24:27 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: sidewinder - mark expected switch fall-throughs

On Wed, Nov 08, 2017 at 09:02:50PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 114763
> Addresses-Coverity-ID: 114764
> Addresses-Coverity-ID: 114765
> Addresses-Coverity-ID: 114766
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Applied, thank you.

> ---
>  drivers/input/joystick/sidewinder.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c
> index 4a95b22..5e602a6 100644
> --- a/drivers/input/joystick/sidewinder.c
> +++ b/drivers/input/joystick/sidewinder.c
> @@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
>  
>  			switch (i * m) {
>  				case 60:
> -					sw->number++;
> +					sw->number++;			/* fall through */
>  				case 45:				/* Ambiguous packet length */
>  					if (j <= 40) {			/* ID length less or eq 40 -> FSP */
>  				case 43:
>  						sw->type = SW_ID_FSP;
>  						break;
>  					}
> -					sw->number++;
> +					sw->number++;			/* fall through */
>  				case 30:
> -					sw->number++;
> +					sw->number++;			/* fall through */
>  				case 15:
>  					sw->type = SW_ID_GP;
>  					break;
> @@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv)
>  						sw->type = SW_ID_PP;
>  					break;
>  				case 66:
> -					sw->bits = 3;
> +					sw->bits = 3;			/* fall through */
>  				case 198:
> -					sw->length = 22;
> +					sw->length = 22;		/* fall through */
>  				case 64:
>  					sw->type = SW_ID_3DP;
>  					if (j == 160)
> -- 
> 2.7.4
> 

-- 
Dmitry