linux-kernel - Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171110182458.zckihuqpiagmhnwx@dtor-ws>
Date:   Fri, 10 Nov 2017 10:24:58 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     Rob Herring <robh+dt@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

On Wed, Nov 08, 2017 at 05:21:03PM +0900, Andi Shyti wrote:
> Hi,
> 
> This patchset adds support for the Samsung s6sy761 touchscreen.
> 
> Thanks,
> Andi

Applied, thank you.

> 
> v5 - v6
>  - make a clear logical split between hw initialization and
>    resume.
>  - fix an inconsistency when applying the maximum x and y
>    coordinates (as discussed with Dmitry[*]).
> 
> [*] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1528801.html
> 
> v4 - v5
>  - The previous patch has been split in two parts as requested
>    by Rob and added his ack in the dt-binding patch.
>  - I tried to fix all the reviews from Dmitry[*]
>  - other random cleanups
> 
> [*] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1523520.html
> 
> v3 - v4
>  - fixed a mismatch on the module name
> 
> v2 - v3
>  - added security check on an unsigned value which can (unlikely)
>    get a "negative" value
> 
>  - in the probe function the interrupt is requested after the
>    input device registration in order to avoid checking in the
>    interrupt handler whether the input device has been registered
> 
>  - removed the 'prev_pm_state' variable. Its original meaning
>    was to restore the state of the device when coming back from
>    sleep mode, but because I removed in patch v2 the low power
>    mode, now the device works only in two modes and therefore
>    'prev_pm_state' is not required any longer.
> 
> v1 - v2
>  - remove the low power functionality as it doesn't bring any
>    benefit
>  - use get_unaligned_be16 instead of the form 'a << 8 | b'
>  - use max_t instead of '? :'
>  - use managed 'devm_device_add_group()'
> 
> 
> Andi Shyti (2):
>   dt-bindings: Input: add Samsung S6SY761 touchscreen binding file
>   Input: add support for the Samsung S6SY761 touchscreen
> 
>  .../bindings/input/touchscreen/samsung,s6sy761.txt |  34 ++
>  drivers/input/touchscreen/Kconfig                  |  11 +
>  drivers/input/touchscreen/Makefile                 |   1 +
>  drivers/input/touchscreen/s6sy761.c                | 564 +++++++++++++++++++++
>  4 files changed, 610 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.txt
>  create mode 100644 drivers/input/touchscreen/s6sy761.c
> 
> -- 
> 2.15.0
> 

-- 
Dmitry