lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Nov 2017 12:28:22 -0800 From: "Luis R. Rodriguez" <mcgrof@...nel.org> To: Pali Rohár <pali.rohar@...il.com> Cc: Ming Lei <ming.lei@...onical.com>, "Luis R. Rodriguez" <mcgrof@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kalle Valo <kvalo@...eaurora.org>, David Gnedt <david.gnedt@...izone.at>, Michal Kazior <michal.kazior@...to.com>, Daniel Wagner <wagi@...om.org>, Tony Lindgren <tony@...mide.com>, Sebastian Reichel <sre@...nel.org>, Pavel Machek <pavel@....cz>, Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, Aaro Koskinen <aaro.koskinen@....fi>, Grazvydas Ignotas <notasas@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-wireless <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function On Fri, Nov 10, 2017 at 12:26 PM, Luis R. Rodriguez <mcgrof@...nel.org> wrote: > even if you *leave* the flag in place and a driver required > this, but the kernel was compiled without CONFIG_FW_LOADER_USER_HELPER then > calling fw_load_from_user_helper would just already return -ENOENT, as such it > would in turn fallback to direct fs loading so the #ifef'ery seems to be not > needed. > The commit log in no way documents any of the justifications for further > extending use of the usermode helper. Also, any new functionality introduced should have a respective test case in tools/testing/selftests/firmware/ and lib/test_firmware.c, as well as extending existing documentation on Documentation/driver-api/firmware/. Luis
Powered by blists - more mailing lists