linux-kernel - [tip:irq/core] irqdomain: Drop pointless NULL check in virq_debug_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4@git.kernel.org>
Date:   Sun, 12 Nov 2017 14:31:42 -0800
From:   tip-bot for Rasmus Villemoes <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, linux-kernel@...r.kernel.org, mingo@...nel.org,
        marc.zyngier@....com, tglx@...utronix.de, linux@...musvillemoes.dk
Subject: [tip:irq/core] irqdomain: Drop pointless NULL check in
 virq_debug_show_one

Commit-ID:  306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4
Gitweb:     https://git.kernel.org/tip/306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4
Author:     Rasmus Villemoes <linux@...musvillemoes.dk>
AuthorDate: Sun, 12 Nov 2017 22:29:03 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sun, 12 Nov 2017 23:25:40 +0100

irqdomain: Drop pointless NULL check in virq_debug_show_one

data has been already derefenced unconditionally, so it's pointless to do a
NULL pointer check on it afterwards. Drop it.

[ tglx: Depersonify changelog. ]

Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Marc Zyngier <marc.zyngier@....com>
Link: https://lkml.kernel.org/r/20171112212904.28574-1-linux@rasmusvillemoes.dk

---
 kernel/irq/irqdomain.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index fbbf342..4f4f600 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -921,8 +921,7 @@ static void virq_debug_show_one(struct seq_file *m, struct irq_desc *desc)
 		chip = irq_data_get_irq_chip(data);
 		seq_printf(m, "%-15s  ", (chip && chip->name) ? chip->name : "none");
 
-		seq_printf(m, data ? "0x%p  " : "  %p  ",
-			   irq_data_get_irq_chip_data(data));
+		seq_printf(m, "0x%p  ", irq_data_get_irq_chip_data(data));
 
 		seq_printf(m, "   %c    ", (desc->action && desc->action->handler) ? '*' : ' ');
 		direct = (irq == hwirq) && (irq < domain->revmap_direct_max_irq);