linux-kernel - Re: [PATCH 4/5] linux/smpboot.h: Apply format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Nov 2017 00:01:08 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
cc:     Kees Cook <keescook@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] linux/smpboot.h: Apply format_template attribute

On Sun, 12 Nov 2017, Rasmus Villemoes wrote:

> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Acked-by: Thomas Gleixner <tglx@...utronix.de>

> ---
>  include/linux/smpboot.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h
> index c174844cf663..967285b9637d 100644
> --- a/include/linux/smpboot.h
> +++ b/include/linux/smpboot.h
> @@ -42,7 +42,7 @@ struct smp_hotplug_thread {
>  	void				(*unpark)(unsigned int cpu);
>  	cpumask_var_t			cpumask;
>  	bool				selfparking;
> -	const char			*thread_comm;
> +	const char			*thread_comm __format_template("foobar/%u");
>  };
>  
>  int smpboot_register_percpu_thread_cpumask(struct smp_hotplug_thread *plug_thread,
> -- 
> 2.11.0
> 
>