linux-kernel - Re: [v8, 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171112064148.GL8522@tassilo.jf.intel.com>
Date:   Sat, 11 Nov 2017 22:41:48 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Andi Kleen <andi@...stfloor.org>, x86@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [v8, 4/5] x86/xsave: Make XSAVE check the base CPUID features
 before enabling

> this patch makes qemu spit out the following warning, possibly because
> it doesn't support all expected CPUID features for the various CPUs.
> 
> WARNING: CPU: 0 PID: 0 at arch/x86/kernel/fpu/xstate.c:614
> 	fpu__init_system_xstate+0x403/0x721
> 
> with associated traceback.
> 
> I understand that this is a qemu problem, but does the traceback really
> add value ?

I agree it could be removed.

-Andi