linux-kernel - Re: [PATCH v4 1/5] fw_cfg: fix the command line module name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171112124030.GB19857@hedwig.ini.cmu.edu>
Date:   Sun, 12 Nov 2017 07:40:30 -0500
From:   "Gabriel L. Somlo" <somlo@....edu>
To:     Marc-André Lureau <marcandre.lureau@...hat.com>
Cc:     linux-kernel@...r.kernel.org, somlo@....edu, qemu-devel@...gnu.org,
        mst@...hat.com
Subject: Re: [PATCH v4 1/5] fw_cfg: fix the command line module name

On Tue, Oct 31, 2017 at 04:19:34PM +0100, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@...hat.com>

Acked-by: Gabriel Somlo <somlo@....edu>

> ---
>  drivers/firmware/qemu_fw_cfg.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 0e2011636fbb..5cfe39f7a45f 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -10,9 +10,9 @@
>   * and select subsets of aarch64), a Device Tree node (on arm), or using
>   * a kernel module (or command line) parameter with the following syntax:
>   *
> - *      [fw_cfg.]ioport=<size>@<base>[:<ctrl_off>:<data_off>]
> + *      [qemu_fw_cfg.]ioport=<size>@<base>[:<ctrl_off>:<data_off>]
>   * or
> - *      [fw_cfg.]mmio=<size>@<base>[:<ctrl_off>:<data_off>]
> + *      [qemu_fw_cfg.]mmio=<size>@<base>[:<ctrl_off>:<data_off>]
>   *
>   * where:
>   *      <size>     := size of ioport or mmio range
> @@ -21,9 +21,9 @@
>   *      <data_off> := (optional) offset of data register
>   *
>   * e.g.:
> - *      fw_cfg.ioport=2@...10:0:1		(the default on x86)
> + *      qemu_fw_cfg.ioport=2@...10:0:1		(the default on x86)
>   * or
> - *      fw_cfg.mmio=0xA@...020000:8:0		(the default on arm)
> + *      qemu_fw_cfg.mmio=0xA@...020000:8:0	(the default on arm)
>   */
>  
>  #include <linux/module.h>
> -- 
> 2.15.0.rc0.40.gaefcc5f6f
>