linux-kernel - Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20171113091629.GQ11226@localhost>
Date:   Mon, 13 Nov 2017 10:16:29 +0100
From:   Johan Hovold <johan@...nel.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable <stable@...r.kernel.org>,
        Peter Ujfalusi <peter.ujfalusi@...com>
Subject: Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup

On Mon, Nov 13, 2017 at 08:30:53AM +0100, H. Nikolaus Schaller wrote:
> Hi Johan,
> 
> > Am 11.11.2017 um 16:43 schrieb Johan Hovold <johan@...nel.org>:
> > 
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at parent rather than just matching on
> > its children.
> > 
> > Later sanity checks on node properties (which would likely be missing)
> > should prevent this from causing much trouble however, especially as the
> > original premature free of the parent node has already been fixed
> > separately (but that "fix" was apparently never backported to stable).
> > 
> > Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
> > Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management")
> > Cc: stable <stable@...r.kernel.org>     # 3.6
> > Cc: Peter Ujfalusi <peter.ujfalusi@...com>
> > Cc: H. Nikolaus Schaller <hns@...delico.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> Tested-By: H. Nikolaus Schaller <hns@...delico.com>	(on Pyra OMAP5 hardware)
> 
> I also tested your twl4030-vibra patch on GTA04.
> 
> No regressions observed.

Thanks for testing.

Johan