linux-kernel - Re: [PATCH] net: realtek: r8169: remove redundant assignment to giga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171113.100853.145554446239802065.davem@davemloft.net>
Date:   Mon, 13 Nov 2017 10:08:53 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: realtek: r8169: remove redundant assignment to
 giga_ctrl

From: Colin King <colin.king@...onical.com>
Date: Wed,  8 Nov 2017 13:23:23 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable giga_ctrl is being assigned to zero however this is
> never read and hence the assignment is redundant, so remove it.
> Cleans up clang warning:
> 
> drivers/net/ethernet/realtek/r8169.c:1978:3: warning: Value stored
> to 'giga_ctrl' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks Colin.