linux-kernel - Re: [PATCH] sched/deadline: fix runtime accounting in documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2de30b8f-0f71-3245-e378-ed1d498fb5e0@redhat.com>
Date:   Mon, 13 Nov 2017 11:39:29 +0100
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Claudio Scordino <claudio@...dence.eu.com>,
        linux-kernel@...r.kernel.org
Cc:     peterz@...radead.org, Luca Abeni <luca.abeni@...tannapisa.it>
Subject: Re: [PATCH] sched/deadline: fix runtime accounting in documentation

On 10/13/2017 12:08 PM, Claudio Scordino wrote:
> Signed-off-by: Claudio Scordino <claudio@...dence.eu.com>
> Signed-off-by: Luca Abeni <luca.abeni@...tannapisa.it>
> ---
>  Documentation/scheduler/sched-deadline.txt | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/scheduler/sched-deadline.txt b/Documentation/scheduler/sched-deadline.txt
> index e89e36e..79f40c6 100644
> --- a/Documentation/scheduler/sched-deadline.txt
> +++ b/Documentation/scheduler/sched-deadline.txt
> @@ -204,10 +204,16 @@ CONTENTS
>   It does so by decrementing the runtime of the executing task Ti at a pace equal
>   to
>  
> -           dq = -max{ Ui, (1 - Uinact) } dt
> +           dq = -max{ Ui / Umax, (1 - Uinact - Uextra) } dt
>  
> - where Uinact is the inactive utilization, computed as (this_bq - running_bw),
> - and Ui is the bandwidth of task Ti.
> + where:
> +
> +  - Ui is the bandwidth of task Ti;

Just one very very small addition to make it more clear:

> +  - Umax is the maximum reclaimable utilization (subject to RT limits);
                                                    ^^^^^^^^^^^^^^^^^^^
				     (subjected to RT Throttling limits)

Anyways,

Acked-by: Daniel Bristot de Oliveira <bristot@...hat.com>

> +  - Uinact is the (per runqueue) inactive utilization, computed as
> +    (this_bq - running_bw);
> +  - Uextra is the (per runqueue) extra reclaimable utilization
> +    (subject to RT limits).
>  
>  
>   Let's now see a trivial example of two deadline tasks with runtime equal
>