linux-kernel - Re: [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c243286-203e-3d05-feb9-7a81a0eb624a@arm.com>
Date:   Mon, 13 Nov 2017 14:39:44 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, tglx@...utronix.de,
        jason@...edaemon.net, kgene@...nel.org, krzk@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 1/3] irqchip/mips-gic: pr_err() strings should end with
 newlines

On 13/11/17 13:53, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/irqchip/irq-mips-gic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index c90976d..e87d33b 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
>  					       gic_shared_intrs, 0,
>  					       &gic_irq_domain_ops, NULL);
>  	if (!gic_irq_domain) {
> -		pr_err("Failed to add GIC IRQ domain");
> +		pr_err("Failed to add GIC IRQ domain\n");
>  		return -ENXIO;
>  	}
>  
> @@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
>  						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
>  						  node, &gic_ipi_domain_ops, NULL);
>  	if (!gic_ipi_domain) {
> -		pr_err("Failed to add GIC IPI domain");
> +		pr_err("Failed to add GIC IPI domain\n");
>  		return -ENXIO;
>  	}
>  
> 

This patch doesn't apply to the current state of the irqchip tree, nor
of tip/irq/core. Please verify that it applies and resubmit if required.

I've applied patches 2 and 3.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...