linux-kernel - RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Nov 2017 02:35:48 +0000
From:   "M.h. Lian" <minghuan.lian@....com>
To:     Leo Li <leoyang.li@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Xiaowei Bao <xiaowei.bao@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Madalin-cristian Bucur <madalin.bucur@....com>,
        "Sumit Garg" <sumit.garg@....com>, "Y.b. Lu" <yangbo.lu@....com>,
        Andy Tang <andy.tang@....com>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "pbrobinson@...il.com" <pbrobinson@...il.com>,
        "songxiaowei@...ilicon.com" <songxiaowei@...ilicon.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "Z.q. Hou" <zhiqiang.hou@....com>,
        "Mingkai Hu" <mingkai.hu@....com>
Subject: RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB



> -----Original Message-----
> From: Leo Li
> Sent: Saturday, November 11, 2017 5:21 AM
> To: Kishon Vijay Abraham I <kishon@...com>; Xiaowei Bao
> <xiaowei.bao@....com>; robh+dt@...nel.org; mark.rutland@....com;
> catalin.marinas@....com; will.deacon@....com; bhelgaas@...gle.com;
> shawnguo@...nel.org; Madalin-cristian Bucur <madalin.bucur@....com>;
> Sumit Garg <sumit.garg@....com>; Y.b. Lu <yangbo.lu@....com>; Andy Tang
> <andy.tang@....com>; jingoohan1@...il.com; pbrobinson@...il.com;
> songxiaowei@...ilicon.com; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
> pci@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org; Z.q. Hou
> <zhiqiang.hou@....com>; Mingkai Hu <mingkai.hu@....com>; M.h. Lian
> <minghuan.lian@....com>
> Subject: RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB
> 
> 
> 
> > -----Original Message-----
> > From: Kishon Vijay Abraham I [mailto:kishon@...com]
> > Sent: Friday, November 10, 2017 12:22 AM
> > To: Xiaowei Bao <xiaowei.bao@....com>; robh+dt@...nel.org;
> > mark.rutland@....com; catalin.marinas@....com; will.deacon@....com;
> > bhelgaas@...gle.com; shawnguo@...nel.org; Madalin-cristian Bucur
> > <madalin.bucur@....com>; Sumit Garg <sumit.garg@....com>; Y.b. Lu
> > <yangbo.lu@....com>; hongtao.jia@....com; Andy Tang
> > <andy.tang@....com>; Leo Li <leoyang.li@....com>;
> > jingoohan1@...il.com; pbrobinson@...il.com; songxiaowei@...ilicon.com;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > linux- kernel@...r.kernel.org; linux-pci@...r.kernel.org; linuxppc-
> > dev@...ts.ozlabs.org; Z.q. Hou <zhiqiang.hou@....com>; Mingkai Hu
> > <mingkai.hu@....com>; M.h. Lian <minghuan.lian@....com>
> > Subject: Re: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB
> > and OB
> >
> > Hi Bao,
> >
> > On Friday 10 November 2017 09:18 AM, Bao Xiaowei wrote:
> > > Add the property of inbound and outbound windows number for ep driver.
> > >
> > > Signed-off-by: Bao Xiaowei <xiaowei.bao@....com>
> > > Acked-by: Minghuan Lian <minghuan.Lian@....com>
> > > ---
> > >  v2:
> > >  - no change
> > >  v3:
> > >  - modify the commit message
> > >  v4:
> > >  - no change
> > >
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> >
> > $subject should start with something like
> > arm64: dts: ls1046a: **
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > index 06b5e12d04d8..f8332669663c 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > @@ -674,6 +674,8 @@
> > >  			device_type = "pci";
> > >  			dma-coherent;
> > >  			num-lanes = <4>;
> > > +			num-ib-windows = <6>;
> > > +			num-ob-windows = <6>;
> >
> > EP specific properties shouldn't be added in RC dt node. Ideally you
> > should have a separate dt node for RC and EP.
> 
> It is a single PCIe controller which can be configured to either RC mode or EP
> mode.  Wouldn't it conflict with the device tree principles to have two device
> tree nodes for the same PCIe controller?  And obviously the two modes cannot
> be used at the same time so we cannot have two drivers both probe on the
> same hardware.
> 
[Minghuan Lian]  There is only one PCIe dts node in the dts file. PCIe dts node describes the PCIe controller's hardware properties and does not have work mode.  The new properties  "num-ib-windows " and "num-ob-windows" are used to describe the inbound/outbound window number included in the PCIe hardware. These windows are used in both RC and EP mode.  We can change work mode when resetting via RCW(reset configuration word).


> Regards,
> Leo